Messages in this thread Patch in this message |  | | From | Julia Lawall <> | | Subject | [PATCH 2/2] drivers/media/rc/imon.c: Correct call to input_free_device | | Date | Sat, 14 May 2011 16:18:55 +0200 |
| |
From: Julia Lawall <julia@diku.dk>
ictx->touch is intialied in imon_init_intf1, to the result of calling the function that contains this code. Thus, in this code, input_free_device should be called on touch itself.
A simplified version of the semantic match that finds this problem is: (http://coccinelle.lip6.fr/)
// <smpl> @r exists@ local idexpression struct input_dev * x; expression ra,rr; position p1,p2; @@
x = input_allocate_device@p1(...) ... when != x = rr when != input_free_device(x,...) when != if (...) { ... input_free_device(x,...) ...} if(...) { ... when != x = ra when forall when != input_free_device(x,...) \(return <+...x...+>; \| return@p2...; \) }
@script:python@ p1 << r.p1; p2 << r.p2; @@
cocci.print_main("input_allocate_device",p1) cocci.print_secs("input_free_device",p2) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/media/rc/imon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c index 8fc0f08..c400318 100644 --- a/drivers/media/rc/imon.c +++ b/drivers/media/rc/imon.c @@ -1982,7 +1982,7 @@ static struct input_dev *imon_init_touch(struct imon_context *ictx) return touch; touch_register_failed: - input_free_device(ictx->touch); + input_free_device(touch); touch_alloc_failed: return NULL;
|  |