Messages in this thread | | | Date | Fri, 13 May 2011 08:33:39 +0200 | From | Jiri Slaby <> | Subject | Re: [PATCH 3/3] checkpatch.pl: Add check for current->comm references |
| |
On 05/13/2011 01:02 AM, John Stultz wrote: > Now that accessing current->comm needs to be protected, > avoid new current->comm usage by adding a warning to > checkpatch.pl. > > Fair warning: I know zero perl, so this was written in the > style of "monkey see, monkey do". It does appear to work > in my testing though. > > Close review and feedback would be appreciated. > > CC: Ted Ts'o <tytso@mit.edu> > CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > CC: David Rientjes <rientjes@google.com> > CC: Dave Hansen <dave@linux.vnet.ibm.com> > CC: Andrew Morton <akpm@linux-foundation.org> > CC: linux-mm@kvack.org > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- > scripts/checkpatch.pl | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index d867081..9d2eab5 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2868,6 +2868,10 @@ sub process { > WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr); > } > > +# check for current->comm usage > + if ($line =~ /current->comm/) {
This should be something like \b(current|task|tsk|t)->comm\b to catch also non-current comm accesses...
> + WARN("comm access needs to be protected. Use get_task_comm, or printk's \%ptc formatting.\n" . $herecurr); > + } > # check for %L{u,d,i} in strings > my $string; > while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
-- js
| |