Messages in this thread |  | | Subject | Re: [PATCH net-next V3] net: af_packet: Untangle packet_snd by adding vpacket_snd | | From | Eric Dumazet <> | | Date | Fri, 13 May 2011 07:11:02 +0200 |
| |
Le jeudi 12 mai 2011 à 16:25 -0700, Joe Perches a écrit : > The current packet_snd handles both vlan and non-vlan frames > with initialization of a struct virtio_net_hdr that is unused > by non-vlan frames. > > Create a new vpacket_snd that uses this virtio_net_hdr and > remove it and the vlan and gso logic from packet_snd. >
1) I find this kind of patches a real pain, frankly.
When I have to look around code and commits to find bugs and bugs origins, I'll have to fully check this kind of patch, and this slow down the process a _lot_, because I have no idea if "Joe Perches" actually tested the patch, or if its yet another "code beautifier" process in the wild.
You should have shooted when/before commit bfd5f4a3 (packet: Add GSO/csum offload support) was accepted.
2) You did not CCed Sridhar Samudrala <sri@us.ibm.com>, the author of above commit. I dont think David will take the time to test your patch.
3) You add some non codingstyle artifacts. I am afraid it makes me nervous for patches bringing no real values but shuffling the code and making maintainers life more difficult.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |