Messages in this thread | | | Date | Fri, 13 May 2011 19:18:42 +0900 | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 2/4] oom: kill younger process first |
| |
(2011/05/12 9:52), KAMEZAWA Hiroyuki wrote: > On Tue, 10 May 2011 17:15:01 +0900 (JST) > KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> wrote: > >> This patch introduces do_each_thread_reverse() and >> select_bad_process() uses it. The benefits are two, >> 1) oom-killer can kill younger process than older if >> they have a same oom score. Usually younger process >> is less important. 2) younger task often have PF_EXITING >> because shell script makes a lot of short lived processes. >> Reverse order search can detect it faster. >> >> Reported-by: CAI Qian<caiqian@redhat.com> >> Signed-off-by: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> > > IIUC, for_each_thread() can be called under rcu_read_lock() but > for_each_thread_reverse() must be under tasklist_lock. > > Could you add some comment ? and prev_task() should use list_entry() > not list_entry_rcu().
Will fix. thanks.
| |