Messages in this thread | | | Date | Thu, 12 May 2011 10:21:59 +0200 | From | Tejun Heo <> | Subject | Re: [patch v2 0/5] percpu_counter: bug fix and enhancement |
| |
Hello,
On Thu, May 12, 2011 at 10:48:13AM +0800, Shaohua Li wrote: > And the atomic64 approach not just improved the performance (which is > always welcomed), but it also fixes a bug for 32-bit system. The usage > of lglock is actually quite straightforward and is standard usage of > lglock (the comments of lglock.h declare such usage), just lglock > doesn't work for dynamatically allocated structure currently, which > needs a convert.
lglock doesn't seem like the right solution for the problem at hand. It's way too heavy handed and used to close a very small race window. It doesn't seem right. Eric's idea seemed much better to me and I don't see why that can't be improved and used instead. Would you be interested in looking that direction?
Thanks.
-- tejun
| |