lkml.org 
[lkml]   [2011]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/17] writeback: introduce writeback_control.inodes_cleaned
    On Thu, May 12, 2011 at 09:57:09PM +0800, Wu Fengguang wrote:
    > The flusher works on dirty inodes in batches, and may quit prematurely
    > if the batch of inodes happen to be metadata-only dirtied: in this case
    > wbc->nr_to_write won't be decreased at all, which stands for "no pages
    > written" but also mis-interpreted as "no progress".
    >
    > So introduce writeback_control.inodes_cleaned to count the inodes get
    > cleaned. A non-zero value means there are some progress on writeback,
    > in which case more writeback can be tried.

    Why introduce a new field for this? Just decrement nr_to_write for
    every write_inode() call made in writeback_single_inode()....

    Cheers,

    Dave.
    --
    Dave Chinner
    david@fromorbit.com


    \
     
     \ /
      Last update: 2011-05-13 00:47    [W:0.022 / U:0.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site