Messages in this thread | | | Date | Thu, 12 May 2011 15:34:11 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 3/3] comm: ext4: Protect task->comm access by using %ptc |
| |
On Thu, 12 May 2011 15:29:40 -0700 John Stultz <john.stultz@linaro.org> wrote:
> On Thu, 2011-05-12 at 15:14 -0700, David Rientjes wrote: > > On Tue, 10 May 2011, John Stultz wrote: > > > > > Converts ext4 comm access to use the safe printk %ptc accessor. > > > > > > CC: Ted Ts'o <tytso@mit.edu> > > > CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > > CC: David Rientjes <rientjes@google.com> > > > CC: Dave Hansen <dave@linux.vnet.ibm.com> > > > CC: Andrew Morton <akpm@linux-foundation.org> > > > CC: linux-mm@kvack.org > > > Signed-off-by: John Stultz <john.stultz@linaro.org> > > > > I like how this patch illustrates how easy it is to use the new method for > > printing a task's command, but it would probably be easier to get the > > first two patches in the series (those that add the seqlock and then %ptc) > > merged in mainline and then break out a series of conversions such as this > > that could go through the individual maintainer's trees. > > Agreed. I just wanted to show how it would be used compared to the > earlier approach. > > I'll respin the first two patches shortly here. I also need to get the > checkpatch bit done. > > Andrew, should these go upstream through you? >
That works. I have a little pile of task->comm patches here, but I expect that resolving everything will be pretty straightforward.
Don't forget the checkpatch patch :)
| |