lkml.org 
[lkml]   [2011]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/11] ptrace: move fallback JOBCTL_TRAPPING clearing to get_signal_to_deliver()
On 05/11, Tejun Heo wrote:
>
> On Wed, May 11, 2011 at 05:48:34PM +0200, Oleg Nesterov wrote:
> > On 05/08, Tejun Heo wrote:
> > > Move the fallback clearing to the end of get_signal_to_deliver() so
> > > that TRAPPING is maintained while tracee is inside signal delivery
> > > path. When killed, tracee is guaranteed to leave signal delivery path
> > > in finite amount of time and thus TRAPPING is still guaranteed to be
> > > cleared on kill.
> >
> > Mostly yes, but we can race with freeze_processes() and deadlock.
>
> Ah... the try_to_freeze(). Nice spotting. It isn't necessarily a
> deadlock tho.

Yes, it is not "fatal" for the system.

> I
> think the right thing to do here is making the TRAPPING sleep an
> interruptible one and let the syscall restart logic deal with it.

Oh, yes, we can. But this adds more complications again. We can fix
this particular problem simpler. Say, freezer_do_not_count(). There
are other options afaics.

> * Make TRAPPING wait INTERRUPTIBLE.

I am starting to strongly dislike TRAPPING outside of do_signal_stop().

> * Move clearing of pending group stop and traps to the actions which
> require such clearing.

Not sure this is enough. OTOH, perhaps this is unnneeded.

I'll write another email to explain what I mean.

Oleg.



\
 
 \ /
  Last update: 2011-05-12 17:43    [W:0.084 / U:8.824 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site