Messages in this thread | | | Date | Wed, 11 May 2011 15:56:04 -0700 | Subject | Re: [PATCH 06/12] staging: usbip: stub_main.c: code cleanup | From | matt mooney <> |
| |
On Wed, May 11, 2011 at 2:08 PM, Greg KH <greg@kroah.com> wrote: > On Wed, May 11, 2011 at 01:54:18AM -0700, matt mooney wrote: >> Reorder functions; remove match_find() and replace with >> get_busid_idx(); change other functions to use get_busid_idx(); and >> code cleanup in the other functions. >> >> Signed-off-by: matt mooney <mfm@muteddisk.com> >> --- >> I apologize for this one. I realize that I should have split it into two with >> the reorder being separate. > > Yes, please split it up.
Okay, I have to try and figure out a sane way of doing this but I will split it.
>> Also, it seems as if there is a synchronization problem carried over from the >> original code in get_busid_priv(). An address into the busid_table is returned >> and then the element is accessed and modified elsewhere. Right? Or am I missing >> something. > > You might be correct, I don't really know. > Yeah I will have to figure that out as I go.
-- GPG-Key: 9AFE00EA
| |