lkml.org 
[lkml]   [2011]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5] PM: Support for system-wide power transitions in generic power domains
    Hi, Rafael,

    One small question that came to mind as I was looking at this patch:

    > +/**
    > + * pm_genpd_powered_down - Check if power has been removed from a power domain.
    > + * @genpd: Power domain to check.
    > + */
    > +static bool pm_genpd_powered_down(struct generic_power_domain *genpd)
    > +{
    > + bool ret;
    > +
    > + mutex_lock(&genpd->lock);
    > + ret = genpd->power_is_off;
    > + mutex_unlock(&genpd->lock);
    > +
    > + return ret;

    I'm not quite sure why this function exists? The lock doesn't really
    change anything, since the power state can change before or after this
    check regardless. If you need the power state to be stable, it seems like
    the lock needs to be taken further up the stack; otherwise simply checking
    genpd->power_is_off directly would seem to be sufficient. Am I missing
    something?

    Thanks,

    jon


    \
     
     \ /
      Last update: 2011-05-11 19:23    [W:0.024 / U:34.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site