lkml.org 
[lkml]   [2011]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch v2 0/5] percpu_counter: bug fix and enhancement
    Hey, Shaohua.

    On Wed, May 11, 2011 at 04:10:12PM +0800, Shaohua Li wrote:
    > The new implementation uses lglock to protect percpu data. Each cpu has its
    > private lock while other cpu doesn't take. In this way _add doesn't need take
    > global lock anymore and remove the deviation. This still gives me about
    > about 5x ~ 6x faster (not that faster than the original 7x faster, but still
    > good) with the workload mentioned in patch 4.

    I'm afraid I'm not too thrilled about lglock + atomic64 usage. It is
    a very patchy approach which addresses a very specific use case which
    might just need a higher @batch. I just can't see enough benefits to
    justify the overhead and complexity. :-(

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2011-05-11 18:59    [W:0.021 / U:35.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site