Messages in this thread | | | From | Paul Turner <> | Date | Wed, 11 May 2011 02:27:34 -0700 | Subject | Re: [patch 05/15] sched: add a timer to handle CFS bandwidth refresh |
| |
On Tue, May 10, 2011 at 12:21 AM, Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> wrote: > (2011/05/03 18:28), Paul Turner wrote: >> @@ -250,6 +253,9 @@ struct cfs_bandwidth { >> ktime_t period; >> u64 quota; >> s64 hierarchal_quota; >> + >> + int idle; >> + struct hrtimer period_timer; >> #endif >> }; >> > > "idle" is not used yet. How about adding it in later patch? > Plus, comment explaining how it is used would be appreciated.
Fixed both. (idle belongs to the accumulate patch)
> >> static void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) >> { >> raw_spin_lock_init(&cfs_b->lock); >> cfs_b->quota = RUNTIME_INF; >> cfs_b->period = ns_to_ktime(default_cfs_period()); >> + >> + hrtimer_init(&cfs_b->period_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); >> + cfs_b->period_timer.function = sched_cfs_period_timer; >> + >> } > > Nit: blank line? > > Reviewed-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> > > > Thanks, > H.Seto > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |