Messages in this thread | | | From | Chris Mason <> | Subject | Re: [PATCHSET v3.1 0/7] data integrity: Stabilize pages during writeback for various fses | Date | Tue, 10 May 2011 12:24:50 -0400 |
| |
Excerpts from Jan Kara's message of 2011-05-10 08:51:24 -0400: > On Mon 09-05-11 16:03:18, Darrick J. Wong wrote: > > I am still chasing down what exactly is broken in ext3. data=writeback mode > > passes with no failures. data=ordered, however, does not pass; my current > > suspicion is that jbd is calling submit_bh on data buffers but doesn't call > > page_mkclean to kick the userspace programs off the page before writing it. > Yes, ext3 in data=ordered mode writes pages from > journal_commit_transaction() via submit_bh() without clearing page dirty > bits thus page_mkclean() is not called for these pages. Frankly, do you > really want to bother with adding support for ext2 and ext3? People can use > ext4 as a fs driver when they want to start using blk-integrity support. > Especially ext2 patch looks really painful and just from a quick look I can > see code e.g. in fs/ext2/namei.c which isn't handled by your patch yet.
I think ext23 are going to be pretty big changes, we're best off just going with ext4.
-chris
| |