Messages in this thread | | | Date | Tue, 10 May 2011 12:40:19 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] kprobes,x86: disable irq durinr optimized callback |
| |
* Jiri Olsa <jolsa@redhat.com> wrote:
> + local_irq_save(flags); > preempt_disable(); > if (kprobe_running()) { > kprobes_inc_nmissed_count(&op->kp); > @@ -1208,6 +1210,7 @@ static void __kprobes optimized_callback(struct optimized_kprobe *op, > __this_cpu_write(current_kprobe, NULL); > } > preempt_enable_no_resched(); > + local_irq_restore(flags);
irq-disable is synonymous to preempt disable so the preempt_disable()/enable() pair looks like superfluous overhead.
Thanks,
Ingo
| |