lkml.org 
[lkml]   [2011]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kprobes,x86: disable irq durinr optimized callback

* Jiri Olsa <jolsa@redhat.com> wrote:

> + local_irq_save(flags);
> preempt_disable();
> if (kprobe_running()) {
> kprobes_inc_nmissed_count(&op->kp);
> @@ -1208,6 +1210,7 @@ static void __kprobes optimized_callback(struct optimized_kprobe *op,
> __this_cpu_write(current_kprobe, NULL);
> }
> preempt_enable_no_resched();
> + local_irq_restore(flags);

irq-disable is synonymous to preempt disable so the preempt_disable()/enable()
pair looks like superfluous overhead.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-10 12:43    [W:0.898 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site