[lkml]   [2011]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 04/11] ptrace: implement PTRACE_INTERRUPT

On Mon, May 09, 2011 at 06:58:57PM +0200, Oleg Nesterov wrote:
> Right now I am a bit puzzled why do we have 2 bits, JOBCTL_TRAP_INTERRUPT
> and JOBCTL_TRAP_SEIZE... But I didn't read this + other patches yet.

It eventually ends up with three trap flags - SEIZE, INTERRUPT and
NOTIFY. They all use PTRACE_EVENT_INTERRUPT trap but are different as
for when they're cleared. SEIZE is cleared after any trap. INTERRUPT
is cleared after an INTERRUPT trap and NOTIFY is cleared after
GETSIGINFO. We can add different pending flags and adjust INTERRUPT
flag according to different pending conditions but I think it's
cleaner to have multiple trap flags than multiplexing things over
single trap flag.

> At first glance, JOBCTL_TRAP_INTERRUPT has the same problem with the
> killed tracee. I think this is easy to fix.

Again, isn't this cleared during __ptrace_unlink()?



 \ /
  Last update: 2011-05-10 11:53    [W:0.166 / U:33.240 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site