lkml.org 
[lkml]   [2011]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tip/core/rcu 23/86] rcu: Use WARN_ON_ONCE for DEBUG_OBJECTS_RCU_HEAD warnings
    Date
    Avoid additional multiple-warning confusion in memory-corruption scenarios.

    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    ---
    kernel/rcupdate.c | 12 ++++++------
    1 files changed, 6 insertions(+), 6 deletions(-)

    diff --git a/kernel/rcupdate.c b/kernel/rcupdate.c
    index b54d6d1..7784bd2 100644
    --- a/kernel/rcupdate.c
    +++ b/kernel/rcupdate.c
    @@ -147,12 +147,12 @@ static int rcuhead_fixup_init(void *addr, enum debug_obj_state state)
    * attempt any fixup and just print a warning.
    */
    #ifndef CONFIG_PREEMPT
    - WARN_ON(1);
    + WARN_ON_ONCE(1);
    return 0;
    #endif
    if (rcu_preempt_depth() != 0 || preempt_count() != 0 ||
    irqs_disabled()) {
    - WARN_ON(1);
    + WARN_ON_ONCE(1);
    return 0;
    }
    rcu_barrier();
    @@ -196,12 +196,12 @@ static int rcuhead_fixup_activate(void *addr, enum debug_obj_state state)
    * attempt any fixup and just print a warning.
    */
    #ifndef CONFIG_PREEMPT
    - WARN_ON(1);
    + WARN_ON_ONCE(1);
    return 0;
    #endif
    if (rcu_preempt_depth() != 0 || preempt_count() != 0 ||
    irqs_disabled()) {
    - WARN_ON(1);
    + WARN_ON_ONCE(1);
    return 0;
    }
    rcu_barrier();
    @@ -233,12 +233,12 @@ static int rcuhead_fixup_free(void *addr, enum debug_obj_state state)
    * attempt any fixup and just print a warning.
    */
    #ifndef CONFIG_PREEMPT
    - WARN_ON(1);
    + WARN_ON_ONCE(1);
    return 0;
    #endif
    if (rcu_preempt_depth() != 0 || preempt_count() != 0 ||
    irqs_disabled()) {
    - WARN_ON(1);
    + WARN_ON_ONCE(1);
    return 0;
    }
    rcu_barrier();
    --
    1.7.3.2


    \
     
     \ /
      Last update: 2011-05-01 15:39    [W:0.024 / U:0.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site