Messages in this thread | | | Date | Sun, 1 May 2011 12:20:40 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH] x86, NUMA: Fix empty memblk detection in numa_cleanup_meminfo() |
| |
Hello,
On Sat, Apr 30, 2011 at 05:43:22PM -0700, Yinghai Lu wrote: > this one works too > but print out is some strange > on 512g system got: > > NUMA: Initialized distance table, cnt=8 > NUMA: Node 0 [0,a0000) + [100000,80000000) -> [0,80000000) > NUMA: Node 0 [0,80000000) + [100000000,1080000000) -> [0,1000000000) > > > first patch on 512g system got > NUMA: Node 0 [0,a0000) + [100000,80000000) -> [0,80000000) > NUMA: Node 0 [0,80000000) + [100000000,1000000000) -> [0,1000000000) > > still thinking first one is more clean.
Yeah, I don't object to the change (it's easier to understand too) but it should be a separate patch because it's unrelated change to the fix itself. If you don't mind sending the splitting part separately, I'll put it on top of the patchset.
Thanks.
-- tejun
| |