lkml.org 
[lkml]   [2011]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 00/69] faster tree-based sysctl implementation
    Date
    Lucian Adrian Grijincu <lucian.grijincu@gmail.com> writes:

    After having read through some of your patches this looks like a good
    overall direction. At a more detailed level there are a lot of pieces
    to your patch series that appear to need some more attention.

    > The first patches remove the .child field of ctl_table. This is a
    > requirement for the new algorithm. These patches are scattered all
    > over the tree :(

    Only registering sysctl leaves seems very reasonable, the code has
    been slowly moving in that direction for quite a while.

    We need to make it a firm rule that directories are created before
    they are used. (aka normal filesystem semantics) before we churn
    through and change everything.

    This also addresses a question you asked in patch 60.

    > This can be fixed in two ways:
    >
    > - A) by making sure to never register a netns specific directory and
    > after that register that directory as a common one. From what I can
    > tell there isn't such a problem in the kernel at the moment, but I
    > did not study the source in detail.

    Currently it is a requirement that if you are going to have a netns
    component and a non nents component the non-netns directory must
    be created first. However that requirement is not currently enforced.

    It is a bit too easy to get that wrong. So we need enforcement of that
    rule and enforcement of duplicate checks. The sysctl_check code should
    become mandatory at this point, or at least the duplicate checks.

    Since we are touching most if not all of the sysctl registrations this
    would also be a good time to pass a path string instead of the weird
    ctl_path data structure. We needed ctl_path when we had both binary
    and proc paths to worry about but we no longer have that concern.

    We may also want to add a special sysctl directory creation and removal
    operations.

    > People interested in the core sysctl changes/networking should read:
    >
    > [PATCH 60/69] sysctl: faster tree-based sysctl implementation
    >
    > which introduces the new algorithm (commit message and comments have
    > more details), and the next few patches which add some further (simple
    > and effective) optimisations for networking (and not only).

    Patch 60 does too many things all in one patch. It would be very good
    if it could be split up some more, so it could be more easily verified.

    Eric


    \
     
     \ /
      Last update: 2011-05-01 17:31    [W:4.043 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site