lkml.org 
[lkml]   [2011]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] ux500: Adding support for u8500 Hsem functionality.
    Hi Mathieu,

    On Fri, Apr 8, 2011 at 11:28 PM, <mathieu.poirier@linaro.org> wrote:
    ...

    > + * Author: Mathieu Poirier <mathieu.poirier@linaro.org>
    > + * Heavily borrowed from the work of :
    > + *   Simon Que <sque@ti.com>
    > + *   Hddari Kanigeri <h-kanigeri2@ti.com>

    s/Hddari/Hari/

    > +       platform_set_drvdata(pdev, state);
    > +
    > +       /* no pm needed for HSem but required to comply
    > +        * with hwspilock core.
    > +        */
    > +       pm_runtime_enable(&pdev->dev);

    You seem to have removed the calls to pm_runtime_disable() throughout
    the driver, is that on purpose ?

    You should see an "Unbalanced pm_runtime_enable!" warning about this
    if you tried rmmod'ing and insmod'ing the driver again.

    And just a minor comment if you're submitting a v2: you have a bunch
    of trailing whitespaces; try checkpatch to spot them easily.

    Thanks,
    Ohad.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-09 09:57    [W:0.021 / U:61.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site