Messages in this thread | | | From | Grant Likely <> | Date | Thu, 7 Apr 2011 09:24:01 -0700 | Subject | Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers |
| |
On Mon, Apr 4, 2011 at 8:04 PM, Grant Likely <grant.likely@secretlab.ca> wrote: > On Mon, Apr 04, 2011 at 12:03:15PM +0200, Samuel Ortiz wrote: >> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h >> index d96db98..734d254 100644 >> --- a/include/linux/platform_device.h >> +++ b/include/linux/platform_device.h >> @@ -14,6 +14,8 @@ >> #include <linux/device.h> >> #include <linux/mod_devicetable.h> >> >> +struct mfd_cell; >> + >> struct platform_device { >> const char * name; >> int id; >> @@ -23,6 +25,9 @@ struct platform_device { >> >> const struct platform_device_id *id_entry; >> >> + /* MFD cell pointer */ >> + struct mfd_cell *mfd_cell; >> + > > Move this down to by the of_node pointer. May as well collect all the > supplemental data about the device in the same place.
So, okay. wow. I have *no* idea what I was smoking at this point in time. The of_node pointer is in struct device which is definitely not the place to put the mfd_cell pointer (and you probably though I was crazy when I suggested it). Greg was totally right to complain about moving it into struct device. Sorry for causing trouble.
Move it back into struct platform_device and you should be good. I just talked to greg, and there should be any issues with locating it there.
g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |