lkml.org 
[lkml]   [2011]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 01/24] sysctl: net: call unregister_net_sysctl_table where needed
    From
    From: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
    Date: Wed, 6 Apr 2011 22:04:53 +0200

    > On Wed, Apr 6, 2011 at 9:52 PM, David Miller <davem@davemloft.net> wrote:
    >> Oops, hmmm...  Can this actually cause any real problems currently?
    >>
    >> If so I'd like to toss this specific patch into net-2.6
    >
    >
    > Nope:
    >
    > void unregister_net_sysctl_table(struct ctl_table_header *header)
    > {
    > unregister_sysctl_table(header);
    > }
    > EXPORT_SYMBOL_GPL(unregister_net_sysctl_table);

    Ok, that's good.

    > But I thought that in the future, if something special needs to be
    > done for unregister_net_sysctl_table, it would be better to have these
    > consistent. I'll do a check on all the tree to see if there are other
    > cases.
    >
    > Another approach would be to remove unregister_net_sysctl_table, as it
    > does nothing different of unregister_sysctl_table and let our future
    > selves deal with the problem.
    >
    > Can you tell me what you'd like?

    I think the thing to do is to keep this patch as it is, and only apply
    it along with this cookie patch series, for -next.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-06 22:28    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean