lkml.org 
[lkml]   [2011]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] rfkill: Regulator consumer driver for rfkill
From
Date
On Wed, 2011-04-06 at 16:21 +0200, Johannes Berg wrote:
> On Wed, 2011-04-06 at 23:11 +0900, Mark Brown wrote:
> > On Wed, Apr 06, 2011 at 11:21:19AM +0200, Antonio Ospite wrote:
> >
> > > + tristate "Generic rfkill regulator driver"
> > > + depends on RFKILL || !RFKILL
> >
> > That looks *odd*.
>
> That's normal for rfkill -- if RFKILL==n then this can be anything since
> the rfkill API goes all no-op inlines, but if RFKILL==m then this can't
> be ==y. "depends on !RFKILL" covers the former, "depends on RFKILL" the
> latter.

But doesn't
depends on RFKILL || !RFKILL

always evaluate to true when running "make *config"? (Even if RFKILL is
an unknown symbol when that expression is parsed!)

I'd say that dependencies such as this one might as well be dropped from
their Kconfig file.


Paul Bolle



\
 
 \ /
  Last update: 2011-04-06 20:15    [W:0.095 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site