lkml.org 
[lkml]   [2011]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 6/7] basic_mmio_gpio: support different input/output registers
    On Wed, Apr 06, 2011 at 12:11:02PM +0100, Jamie Iles wrote:
    > Some controllers have separate input and output registers. For these
    > controllers, allow a register named "in" to be used for reading the
    > value of a GPIO pin.
    >
    > Signed-off-by: Jamie Iles <jamie@jamieiles.com>
    > Cc: Anton Vorontsov <cbouatmailru@gmail.com>
    > Cc: Grant Likely <grant.likely@secretlab.ca>
    > ---
    [...]
    > @@ -316,6 +340,8 @@ static int __devinit bgpio_probe(struct platform_device *pdev)
    > if (!bgc->reg_dat)
    > return -ENOMEM;
    >
    > + spin_lock_init(&bgc->lock);
    > +

    Hm. This looks like a stray change, now bgpio_probe() calls spin_lock_init()
    twice.

    Other than that, the patch seems to be OK.

    Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>

    Thanks,

    --
    Anton Vorontsov
    Email: cbouatmailru@gmail.com


    \
     
     \ /
      Last update: 2011-04-06 14:19    [W:2.129 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site