Messages in this thread | | | Date | Wed, 6 Apr 2011 16:16:01 +0400 | From | Anton Vorontsov <> | Subject | Re: [RFC PATCH 6/7] basic_mmio_gpio: support different input/output registers |
| |
On Wed, Apr 06, 2011 at 12:11:02PM +0100, Jamie Iles wrote: > Some controllers have separate input and output registers. For these > controllers, allow a register named "in" to be used for reading the > value of a GPIO pin. > > Signed-off-by: Jamie Iles <jamie@jamieiles.com> > Cc: Anton Vorontsov <cbouatmailru@gmail.com> > Cc: Grant Likely <grant.likely@secretlab.ca> > --- [...] > @@ -316,6 +340,8 @@ static int __devinit bgpio_probe(struct platform_device *pdev) > if (!bgc->reg_dat) > return -ENOMEM; > > + spin_lock_init(&bgc->lock); > +
Hm. This looks like a stray change, now bgpio_probe() calls spin_lock_init() twice.
Other than that, the patch seems to be OK.
Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
Thanks,
-- Anton Vorontsov Email: cbouatmailru@gmail.com
| |