lkml.org 
[lkml]   [2011]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Make all it87 drivers SMP safe.
    On Tue, Apr 05, 2011 at 07:03:35PM -0400, Natarajan Gurumoorthy wrote:
    > Guenter,
    > This patch patch applies a common fix to all IT87 driver. Separating it
    > into 2 patches (one for drivers/hwmon and one for drivers/watchdog) does not
    > seem to be the right thing to do. I think having all the patches in one file
    > makes it easier to understand the rationale behind the patch. The
    > it87_io_lock.c and it87_io_lock.h files are in drivers/watchdog directory and
    > the lock defined in it is needed by the changes in drivers/hwmon/it87.c
    >

    I dislike the idea of a single patch crossing multiple subsystems. Maybe you'll
    find another maintainer accepting your change as a single patch, but I won't.

    That doesn't mean that the patches would have to be committed into multiple trees.
    That is for the subsystem maintainers to sort out, and a different issue.

    Thanks,
    Guenter


    \
     
     \ /
      Last update: 2011-04-06 02:09    [W:4.559 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site