lkml.org 
[lkml]   [2011]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/16] Staging: hv: Add the inclusion guard for vstorage.h
    On Mon, Apr 04, 2011 at 09:28:05PM -0700, Greg KH wrote:
    > On Wed, Mar 23, 2011 at 10:50:19AM -0700, K. Y. Srinivasan wrote:
    > > In preparation for getting rid of the inclusion of storvsc.c from
    > > blkvsc.c, add inclusion guard to vstorage.h
    > >
    > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
    > > Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
    > > ---
    > > drivers/staging/hv/vstorage.h | 5 +++++
    > > 1 files changed, 5 insertions(+), 0 deletions(-)
    > >
    > > diff --git a/drivers/staging/hv/vstorage.h b/drivers/staging/hv/vstorage.h
    > > index ebb4d67..83060cd 100644
    > > --- a/drivers/staging/hv/vstorage.h
    > > +++ b/drivers/staging/hv/vstorage.h
    > > @@ -25,6 +25,9 @@
    > > /* to alert the user that structure sizes may be mismatched even though the */
    > > /* protocol versions match. */
    > >
    > > +#ifndef _VSTORAGE_H_
    > > +#define _VSTORAGE_H_
    >
    > What's with the trailing '_'?
    >
    > Traditionally we've used __FOO_H for internal kernel header files.

    Oh nevermind, I see that's how the other .h files in this directory
    work, it's ok for now.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2011-04-05 09:37    [W:0.025 / U:1.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site