lkml.org 
[lkml]   [2011]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/12] Staging: hv: Cleanup irq management
On Tue, Mar 15, 2011 at 03:03:34PM -0700, K. Y. Srinivasan wrote:
> Now that vmbus_driver is a pci driver,
> cleanup the irq allocation mess by using the standard
> irq allocation mechanisms.
>
> Note that this patch generates an error when the checkpatch
> script is run because of the IRQF_SAMPLE_RANDOM flag used in
> request_irq() function. This interrupt may be the only
> external event this VM will get and consequently if this
> flag (IRQF_SAMPLE_RANDOM) is not specified, experimentally
> we have shown that the entropy in the VM will very very low.
>
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: Mike Sterling <mike.sterling@microsoft.com>
> Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
> Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
> ---
> drivers/staging/hv/vmbus_drv.c | 28 +++++++++++++---------------
> 1 files changed, 13 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
> index 3d2789b..239b91c 100644
> --- a/drivers/staging/hv/vmbus_drv.c
> +++ b/drivers/staging/hv/vmbus_drv.c
> @@ -17,6 +17,8 @@
> * Authors:
> * Haiyang Zhang <haiyangz@microsoft.com>
> * Hank Janssen <hjanssen@microsoft.com>
> + *
> + * 3/9/2011: K. Y. Srinivasan - Significant restructuring and cleanup

Changelog comments never belong in the file itself. If you consider
yourself an author of the file now, then put your name in it with the
others.

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-04-05 09:37    [from the cache]
©2003-2011 Jasper Spaans