Messages in this thread | | | Date | Tue, 05 Apr 2011 10:36:39 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH] ARM: BUG() dies silently |
| |
On 4/4/2011 6:55 PM, Simon Glass wrote: > On Sun, Apr 3, 2011 at 12:15 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: >> Yes I've seen your patch (and even posted comments on it which have not >> been responded to). > Hi Stephen, > > Not yet! Don't worry I will get to it. I like the suggestion and am > pleased that you pointed me to it, thank you. >
Great!
>> Correct me if I'm wrong, but that patch with CONFIG_BUG=n would lead to >> the same error that Omar is seeing because the code only modifies the >> bug infrastructure when CONFIG_BUG=y. > Well if CONFIG_BUG=n then there is no bug infrastructure, The whole > file is skipped and it falls back to the asm-generic/bug.h which has > even more #ifdefs in it. But I think we end up here: > > #define BUG() do {} while(0) > > After all the patch removes the *(int*)0 = 0 code by virtue of > CONFIG_GENERIC_BUG=y, right? If I have this wrong then I will have to > break out the C preprocessor... >
Ah you're right. Too many ifdefs going on there.
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
| |