lkml.org 
[lkml]   [2011]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCHv2 1/5] hwmon: lis3: Free regulators if probe() fails.
    Date
    Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
    ---
    drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 9 +++++++--
    1 files changed, 7 insertions(+), 2 deletions(-)

    diff --git a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
    index b20dfb4..ea9159c 100644
    --- a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
    +++ b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
    @@ -161,8 +161,13 @@ static int __devinit lis3lv02d_i2c_probe(struct i2c_client *client,
    if (lis3_dev.reg_ctrl)
    lis3_reg_ctrl(&lis3_dev, LIS3_REG_OFF);

    - if (ret == 0)
    - return 0;
    + if (ret)
    + goto fail2;
    + return 0;
    +
    +fail2:
    + regulator_bulk_free(ARRAY_SIZE(lis3_dev.regulators),
    + lis3_dev.regulators);
    fail:
    if (pdata && pdata->release_resources)
    pdata->release_resources();
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2011-04-05 16:51    [W:2.308 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site