| Subject | Re: [patch 10/15] sched: (fixlet) dont update shares twice on on_rq parent | From | Peter Zijlstra <> | Date | Tue, 05 Apr 2011 15:28:11 +0200 |
| |
On Tue, 2011-03-22 at 20:03 -0700, Paul Turner wrote: > In dequeue_task_fair() we bail on dequeue when we encounter a parenting entity > with additional weight. However, we perform a double shares update on this > entity since we continue the shares update traversal from that point, despite > dequeue_entity() having already updated its queuing cfs_rq. > > Avoid this by starting from the parent when we resume.
I'm thinking this fixlet is orthogonal to the rest of this patch-set and should go in now? (Usually such things live at the head of a series)
|