lkml.org 
[lkml]   [2011]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 10/15] sched: (fixlet) dont update shares twice on on_rq parent
From
Date
On Tue, 2011-03-22 at 20:03 -0700, Paul Turner wrote:
> In dequeue_task_fair() we bail on dequeue when we encounter a parenting entity
> with additional weight. However, we perform a double shares update on this
> entity since we continue the shares update traversal from that point, despite
> dequeue_entity() having already updated its queuing cfs_rq.
>
> Avoid this by starting from the parent when we resume.

I'm thinking this fixlet is orthogonal to the rest of this patch-set and
should go in now? (Usually such things live at the head of a series)


\
 
 \ /
  Last update: 2011-04-05 15:33    [W:2.195 / U:1.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site