lkml.org 
[lkml]   [2011]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: linux-next: Tree for April 4 [BROKEN thinkpad_acpi]
Date
On Mon, 04 Apr 2011 14:00 +0100, "Matthew Garrett" <mjg@redhat.com> wrote:
> On Mon, Apr 04, 2011 at 05:49:29AM -0700, Joe Perches wrote:
>
> > It's vdbg_printk no_printk verification.
> >
> > #ifdef CONFIG_THINKPAD_ACPI_DEBUG
> > #define vdbg_printk dbg_printk
> > static const char *str_supported(int is_supported);
> > #else
> > #define vdbg_printk(a_dbg_level, format, arg...) \
> > no_printk(format, ##arg)
> > #endif
> >
> > Two ways to handle this.
> >
> > 1: add
> > static inline const char *str_supported(int is_supported) { return ""; }
> > to the #else
> >
> > 2: Remove no_printk verification and return it to do {} while (0)
> >
> > Do you have a preference?
>
> I don't. Henrique?

No set preference, either way is fine.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh



\
 
 \ /
  Last update: 2011-04-05 14:31    [from the cache]
©2003-2011 Jasper Spaans