Messages in this thread | | | Date | Mon, 4 Apr 2011 11:36:20 +0200 | From | Dominik Brodowski <> | Subject | Re: [PATCH] X86:NET:Replaced a deprecated function . |
| |
On Mon, Apr 04, 2011 at 05:32:28PM +0800, wanlong.gao@gmail.com wrote: > From: Wanlong Gao <wanlong.gao@gmail.com> > > kernel_warning: pcmcia_request_exclusive_irq is deprecated .
NACK. This papers over the issue, instead of fixing it. To properly fix it, one needs to verify that the IRQ handler used in this driver is capable of handling a shared IRQ line.
Best, Dominik
> Signed-off-by: Wanlong Gao <wanlong.gao@gmail.com> > --- > drivers/net/pcmcia/nmclan_cs.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/pcmcia/nmclan_cs.c b/drivers/net/pcmcia/nmclan_cs.c > index 76683d9..bf97231 > --- a/drivers/net/pcmcia/nmclan_cs.c > +++ b/drivers/net/pcmcia/nmclan_cs.c > @@ -625,7 +625,7 @@ static int nmclan_config(struct pcmcia_device *link) > ret = pcmcia_request_io(link); > if (ret) > goto failed; > - ret = pcmcia_request_exclusive_irq(link, mace_interrupt); > + ret = __pcmcia_request_exclusive_irq(link, mace_interrupt); > if (ret) > goto failed; > ret = pcmcia_enable_device(link); > -- > 1.7.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |