lkml.org 
[lkml]   [2011]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2 2/2] thinkpad_acpi: Convert printks to pr_<level>
From
Date
On Mon, 2011-04-04 at 20:03 +0200, Sedat Dilek wrote:
> On Mon, Apr 4, 2011 at 7:06 PM, Joe Perches <joe@perches.com> wrote:
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> [...]
> > #ifdef CONFIG_THINKPAD_ACPI_DEBUG
> > #define vdbg_printk dbg_printk
> > static const char *str_supported(int is_supported);
> > #else
> > -#define vdbg_printk(a_dbg_level, format, arg...) \
> > - do { } while (0)
> > +static inline const char *str_supported(int is_supported) { return ""; }
> > +#define vdbg_printk(a_dbg_level, format, arg...) \
> > + no_printk(format, ##arg)
> > #endif
>
> Should be...
> + do { } while (0)
> ...not...
> + no_printk(format, ##arg)

I disagree. No printk serves as a mechanism to verify
printk arguments when !CONFIG_THINKPAD_ACPI_DEBUG.




\
 
 \ /
  Last update: 2011-04-04 20:13    [from the cache]
©2003-2011 Jasper Spaans