Messages in this thread Patch in this message | | | Date | Sat, 30 Apr 2011 14:33:30 +0200 | From | Tejun Heo <> | Subject | [PATCH] x86, NUMA: Fix empty memblk detection in numa_cleanup_meminfo() |
| |
From: Yinghai Lu <yinghai@kernel.org>
numa_cleanup_meminfo() trims each memblk between low (0) and high (max_pfn) limits and discard empty ones. However, the emptiness detection incorrectly used equality test. If the start of a memblk is higher than max_pfn, it is empty but fails the equality test and doesn't get discarded.
Fix it by using >= instead of ==.
Signed-off-by: Yinghai Lu <yinghai@kernel.org> Signed-off-by: Tejun Heo <tj@kernel.org> --- So, something like this. Does this fix the problem you see?
Thanks.
arch/x86/mm/numa_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: work/arch/x86/mm/numa_64.c =================================================================== --- work.orig/arch/x86/mm/numa_64.c +++ work/arch/x86/mm/numa_64.c @@ -191,7 +191,7 @@ int __init numa_cleanup_meminfo(struct n bi->end = min(bi->end, high); /* and there's no empty block */ - if (bi->start == bi->end) { + if (bi->start >= bi->end) { numa_remove_memblk_from(i--, mi); continue; }
| |