Messages in this thread | | | Date | Sat, 30 Apr 2011 16:58:11 -0400 (EDT) | From | Vince Weaver <> | Subject | Re: re-enable Nehalem raw Offcore-Events support |
| |
On Fri, 29 Apr 2011, Vince Weaver wrote:
> > https://lkml.org/lkml/2011/4/22/281 > > > > So here's my review: > NACK
so a slightly more useful review on slightly more sleep.
You are doing things backwards with your "generalization first" policy.
The right way to do things is enable raw event support first.
Then you can have users experiment with the feature. Try various events using their favorite userspace utility (be it libpfm4, PAPI, perf). This is easy, as choosing a new event is a simple matter of changing the command line option for your measurement. Once a good event is found for generalization, *THEN* you add a generalized event that is well tested.
Your way is difficult. Fine, Peter picks some arbitrary event he thinks work well. I have to download a git kernel and reboot my machine (a process that takes an hour at best assuming I have root access). Then if I want to try a new event, since RAW access is blocked, I have to patch the kernel, recompile, reboot. So at least an hour between tests.
This assumes I can even do that. My only Nehalem machine is at work and has only a fragile wireless network connection that requires manual intervention to get going. so I *can't* review a change in general events with a remove access when it lives in the kernel, yet if it was in user space like it *should be* I could test away all day no problem.
See the problem here? Going general event first makes it seriously inconvenient to test and so noone is going to do it for you because it's such a pain. RAW first is the way to go.
Vince
| |