lkml.org 
[lkml]   [2011]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHSET tip] x86, NUMA: Unify 32 and 64bit NUMA initialization
On 04/30/2011 05:17 AM, Tejun Heo wrote:
> Hello, Yinghai.
>
> Nice catch, but,
>
> On Fri, Apr 29, 2011 at 01:14:14PM -0700, Yinghai Lu wrote:
>> [PATCH] x86, numa: Trim numa meminfo correctly
>>
>> During testing 32bit numa unifying code from tj, found one system with more than 64g
>> fail to use numa.
>>
>> It turn out we do not trim that numa meminfo correctly with max_pfn.
>> start could be bigger than 64g too.
>>
>> Also need to make the checking in seperated loop.
>
> Why?

so do not need to compare them with low/high in following inner loop.


>
> Isn't all that necessary the following?
>
> ---
> arch/x86/mm/numa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: work/arch/x86/mm/numa.c
> ===================================================================
> --- work.orig/arch/x86/mm/numa.c
> +++ work/arch/x86/mm/numa.c
> @@ -278,7 +278,7 @@ int __init numa_cleanup_meminfo(struct n
> bi->end = min(bi->end, high);
>
> /* and there's no empty block */
> - if (bi->start == bi->end) {
> + if (bi->start >= bi->end) {
> numa_remove_memblk_from(i--, mi);
> continue;
> }



\
 
 \ /
  Last update: 2011-04-30 18:35    [W:0.058 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site