lkml.org 
[lkml]   [2011]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RESEND PATCH 1/2] perf probe: Fix the missed parameter initialization
From
Date
On Fri, 2011-04-29 at 17:44 +0800, Ingo Molnar wrote:
> * Lin Ming <ming.m.lin@intel.com> wrote:
>
> > pubname_callback_param::found should be initialized to 0 in fastpath lookup.
> >
> > Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> > ---
> > tools/perf/util/probe-finder.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> > index a7c7145..3b9d0b8 100644
> > --- a/tools/perf/util/probe-finder.c
> > +++ b/tools/perf/util/probe-finder.c
> > @@ -1538,6 +1538,7 @@ static int find_probes(int fd, struct probe_finder *pf)
> > .file = pp->file,
> > .cu_die = &pf->cu_die,
> > .sp_die = &pf->sp_die,
> > + .found = 0,
>
> Hm, why is this a 'misc cleanup'? If this field is uninitialized (it does

I should call it 'misc cleanup and fix'.

> appear so) and we rely on the field then right now this is a bug and the fix
> should be pushed to perf/urgent.

Indeed.

>
> Thanks,
>
> Ingo




\
 
 \ /
  Last update: 2011-04-29 15:21    [from the cache]
©2003-2011 Jasper Spaans