lkml.org 
[lkml]   [2011]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[08/55] nfsd4: Fix filp leak
    2.6.38-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

    commit a96e5b90804be8b540d30f4a1453fc87f95b3149 upstream.

    23fcf2ec93fb8573a653408316af599939ff9a8e (nfsd4: fix oops on lock failure)

    The above patch breaks free path for stp->st_file. If stp was inserted
    into sop->so_stateids, we have to free stp->st_file refcount. Because
    stp->st_file refcount itself is taken whether or not any refcounts are
    taken on the stp->st_file->fi_fds[].

    Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/nfsd/nfs4state.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/nfsd/nfs4state.c
    +++ b/fs/nfsd/nfs4state.c
    @@ -403,8 +403,8 @@ static void free_generic_stateid(struct
    if (stp->st_access_bmap) {
    oflag = nfs4_access_bmap_to_omode(stp);
    nfs4_file_put_access(stp->st_file, oflag);
    - put_nfs4_file(stp->st_file);
    }
    + put_nfs4_file(stp->st_file);
    kmem_cache_free(stateid_slab, stp);
    }




    \
     
     \ /
      Last update: 2011-04-29 21:13    [W:3.995 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site