Messages in this thread | | | Date | Fri, 29 Apr 2011 02:38:55 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 2/2] x86: Change trap definitions to enumerated values |
| |
On Fri, 22 Apr 2011, Vaibhav Nagarnaik wrote:
> From: Aditya Kali <adityakali@google.com> > > The traps are referred to by their numbers and it can be difficult to > understand them while reading the code without context. This patch adds > enumeration of the trap numbers and replaced the numbers to the correct > enum for x86.
I really like that patch, but it should have been 1/2 as it has a value independent of the trap trace stuff.
And if you had done that, then the trap trace patch could have used those symbols instead of the numbers as well.
Now that's the 2/2 patch and leaves the (not so) shiny new trace points with those weird numbers. :(
Thanks,
tglx
| |