Messages in this thread | | | Date | Thu, 28 Apr 2011 22:56:39 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] audio: tlv320aic26: fix PLL register configuration |
| |
On Thu, Apr 28, 2011 at 05:32:57PM -0400, Michael Williamson wrote:
> - jval = (fsref == 44100) ? 7 : 8; > - dval = (fsref == 44100) ? 5264 : 1920; > + jval = fsref / (aic26->mclk / 2048); > + dval = fsref - jval * (aic26->mclk / 2048);
I'd like some more brackets on this line, especially given the similarity with the previous line. Otherwise this looks fine if a bit magic:
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
| |