Messages in this thread Patch in this message | | | Subject | Re: [PATCH] Staging: Westbridge: replace custom debug macros with pr_...() macros | Date | Thu, 28 Apr 2011 21:40:07 +0200 | From | "Michal Nazarewicz" <> |
| |
On Thu, 28 Apr 2011 20:48:41 +0200, Sutharsan <sutharsan.tech@gmail.com> wrote: > @@ -2121,7 +2121,7 @@ static int cyasgadget_initialize(void) > cy_as_dev->dev_handle = cyasdevice_getdevhandle(); > if (0 == cy_as_dev->dev_handle) { > #ifndef NDEBUG > - cy_as_hal_print_message("<1> cy_as_gadget: " > + pr_debug("<1> cy_as_gadget: " > "no west bridge device\n"); > #endif > retval = -EFAULT;
That's actually incorrect. You should not have "<1>" in the string. Not only that, "<1>" means that the message was actually KERN_ALERT not KERN_DEBUG -- it looks like that is a mistake though. At any rate, though, if you are using pr_debug() you don't need to check for NDEBUG macro.
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +-----<email/xmpp: mnazarewicz@google.com>-----ooO--(_)--Ooo--
| |