Messages in this thread | | | Date | Thu, 28 Apr 2011 14:42:34 -0400 | From | Jason Baron <> | Subject | Re: [PATCH] jump label: Fix jump_label_text_reserved |
| |
On Thu, Apr 28, 2011 at 01:53:43PM -0400, Anders Kaseorg wrote: > This typo prevented jump_label_text_reserved from checking for any > conflicts in the core kernel. > > Signed-off-by: Anders Kaseorg <andersk@ksplice.com> > --- > kernel/jump_label.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/jump_label.c b/kernel/jump_label.c > index 3b79bd9..4aedde1 100644 > --- a/kernel/jump_label.c > +++ b/kernel/jump_label.c > @@ -250,7 +250,7 @@ int jump_label_text_reserved(void *start, void *end) > { > struct jump_entry *iter; > struct jump_entry *iter_start = __start___jump_table; > - struct jump_entry *iter_stop = __start___jump_table; > + struct jump_entry *iter_stop = __stop___jump_table; > int conflict = 0; > > iter = iter_start; > -- > 1.7.5 >
This is fixed in the jump label re-write patch, which is queued for 2.6.40 in the -tip tree. See: http://marc.info/?l=linux-kernel&m=130391786701337&w=2
I believe only kprobes is relying on this check. Did you hit this in practive using kprobes?
Thanks,
-Jason
| |