lkml.org 
[lkml]   [2011]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCHv4 2/7] ethtool: Call ethtool's get/set_settings callbacks with cleaned data
    Hi,

    Stanislaw, as Ben mentions, it's calling phy_ethtool_sset() which is
    certainly meant to be an ETHTOOL_SSET op (from its name and comments)
    even though its current implementation doesn't actually care for the
    value of the cmd field.

    Regards,

    --
    David Decotigny



    On Thu, Apr 28, 2011 at 12:34 AM, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
    > On Wed, Apr 27, 2011 at 09:32:38PM -0700, David Decotigny wrote:
    >> --- a/drivers/net/stmmac/stmmac_ethtool.c
    >> +++ b/drivers/net/stmmac/stmmac_ethtool.c
    >> @@ -237,13 +237,12 @@ stmmac_set_pauseparam(struct net_device *netdev,
    >>
    >>       if (phy->autoneg) {
    >>               if (netif_running(netdev)) {
    >> -                     struct ethtool_cmd cmd;
    >> +                     struct ethtool_cmd cmd = { .cmd = ETHTOOL_SSET };
    >>                       /* auto-negotiation automatically restarted */
    >> -                     cmd.cmd = ETHTOOL_NWAY_RST;
    >
    > Why did you change ETHTOOL_NWAY_RST to ETHTOOL_SSET ?
    >
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-28 17:19    [W:0.038 / U:6.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site