lkml.org 
[lkml]   [2011]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH] cpuset: fix cpuset_cpus_allowed_fallback() don't update tsk->rt.nr_cpus_allowed
    Date
    Oleg, Peter,

    I apologize if I misunderstand a code. I'm afraid we need following
    patch. Is there any gurantte that cpusets user task is not RT task?



    From 400e24f7b6e15d1397dc82d74fdd1e0a631493ef Mon Sep 17 00:00:00 2001
    From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Date: Thu, 28 Apr 2011 16:14:16 +0900
    Subject: [PATCH] cpuset: fix cpuset_cpus_allowed_fallback() don't update tsk->rt.nr_cpus_allowed

    The rule is, we have to update tsk->rt.nr_cpus_allowed too if we change
    tsk->cpus_allowed.

    Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Ingo Molnar <mingo@elte.hu>
    ---
    include/linux/cpuset.h | 1 +
    kernel/cpuset.c | 1 +
    2 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
    index f20eb8f..42dcbdc 100644
    --- a/include/linux/cpuset.h
    +++ b/include/linux/cpuset.h
    @@ -147,6 +147,7 @@ static inline void cpuset_cpus_allowed(struct task_struct *p,
    static inline int cpuset_cpus_allowed_fallback(struct task_struct *p)
    {
    cpumask_copy(&p->cpus_allowed, cpu_possible_mask);
    + p->rt.nr_cpus_allowed = cpumask_weight(&p->cpus_allowed);
    return cpumask_any(cpu_active_mask);
    }

    diff --git a/kernel/cpuset.c b/kernel/cpuset.c
    index 1ceeb04..6e5bbe8 100644
    --- a/kernel/cpuset.c
    +++ b/kernel/cpuset.c
    @@ -2220,6 +2220,7 @@ int cpuset_cpus_allowed_fallback(struct task_struct *tsk)
    cpumask_copy(&tsk->cpus_allowed, cpu_possible_mask);
    cpu = cpumask_any(cpu_active_mask);
    }
    + tsk->rt.nr_cpus_allowed = cpumask_weight(&tsk->cpus_allowed);

    return cpu;
    }
    --
    1.7.3.1




    \
     
     \ /
      Last update: 2011-04-28 16:23    [W:0.024 / U:0.852 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site