Messages in this thread | | | Date | Thu, 28 Apr 2011 11:50:29 +0200 | From | Robert Richter <> | Subject | Re: [PATCH v2] perf, x86: Fix event scheduler for constraints with overlapping counters |
| |
On 19.04.11 15:55:18, Robert Richter wrote: > On 19.04.11 07:29:33, Ingo Molnar wrote: > > > > * Robert Richter <robert.richter@amd.com> wrote: > > > > > + if (!state) > > > + /* no events to reschedule */ > > > + goto done; > > > > Hm, that's 5 levels of indentation. Would it be possible to factor out the gist > > of the logic into a helper and such? My eyes would be much happier! > > Hmm, I was thinking about this too, but it is not easy since we > control also the loops with goto's and updates of the loop > states. Refactoring out the inner block would mean to update state > varables via pointers and to introduce return codes which contains > control flow information. Don't think this will become easier. > > We could probably merge both for-loops in one while-loop but also on > costs of code readability.
Ingo, do you still want me to rework it?
Any other comments on this patch?
Thanks,
-Robert
-- Advanced Micro Devices, Inc. Operating System Research Center
| |