Messages in this thread | | | Date | Wed, 27 Apr 2011 22:46:07 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH v3.2] kbuild: implement several W= levels |
| |
On Wed, Apr 27, 2011 at 01:21:00PM -0700, Joe Perches wrote: > On Wed, 2011-04-27 at 22:15 +0200, Borislav Petkov wrote: > > From: Sam Ravnborg <sam@ravnborg.org> > [] > > +warning-1 += -Wold-style-definition > > +warning-1 += $(call cc-option, -Wmissing-include-dirs) > > Only thing I would suggest is a comment describing why > some entries use $(call cc-option, -Wfoo) and others don't. > > Something akin to: > > # Use call cc-option when the minimum supported gcc version does not > # support a specific option but a later gcc version does.
From the patch: +# $(call cc-option, -W...) handles gcc -W.. options which # are not supported by all versions of the compiler
So it is already included.
Sam
| |