lkml.org 
[lkml]   [2011]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio
On Wednesday, April 27, 2011 6:13 AM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> This rewrites the U300 GPIO driver using gpiolib and the irq_chip
> abstractions, makes it runtime-configured rather than compile-time,
> and moves it to the drivers/gpio subsystem where it belongs,
> depopulating the ARM tree of one more driver.
>
> Cc: Jonas Aaberg <jonas.aberg@stericsson.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

If this and other platform-specific GPIO drivers are going to be
moved to the drivers/gpio subsystem, the Kconfig and Makefile should
probably be updated to reflect this.

In drivers/gpio/Kconfig:

#
# platform-neutral GPIO infrastructure and expanders
#

And in drivers/gpio/Makefile:

# generic gpio support: dedicated expander chips, etc
#
# NOTE: platform-specific GPIO drivers don't belong in the
# drivers/gpio directory; put them with other platform setup
# code, IRQ controllers, board init, etc.

The Makefile should probably be reordered, either alphabetically
or grouped by type (arch/mmio/i2c/spi/pci/etc) and then
alphabetically in order to reduce merge conflicts.

Regards,
Hartley

\
 
 \ /
  Last update: 2011-04-27 20:27    [from the cache]
©2003-2011 Jasper Spaans