lkml.org 
[lkml]   [2011]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kbuild: don't warn about linux/version.h not including itself
    On 25.4.2011 01:27, Peter Foley wrote:
    > This patch makes checkversion.pl not warn that include/linux/version.h
    > dosen't include itself.
    >
    > Signed-off-by: Peter Foley <pefoley2@verizon.net>
    > ---
    > scripts/checkversion.pl | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
    > index b444e89..b9150c7 100755
    > --- a/scripts/checkversion.pl
    > +++ b/scripts/checkversion.pl
    > @@ -47,7 +47,7 @@ foreach my $file (@ARGV) {
    > }
    >
    > # Report used version IDs without include?
    > - if ($fUseVersion && ! $iLinuxVersion) {
    > + if ($fUseVersion && ! $iLinuxVersion && $file !~ "include/linux/version.h") {

    A more obvious fix would be to check the filename right at the beginning
    of the loop and skip to the next iteration if it is version.h. Also, you
    should escape the '.' in the regexp.

    Michal


    \
     
     \ /
      Last update: 2011-04-26 22:37    [W:0.021 / U:0.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site