Messages in this thread | | | Date | Tue, 26 Apr 2011 21:31:36 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 2/6] dmaengine/dw_dmac: Enable resubmission from callback routine. |
| |
On Tue, Apr 19, 2011 at 11:42:24AM +0530, Koul, Vinod wrote: > On 04/18/2011 04:20 PM, viresh kumar wrote: > > > > Resubmission of new transfer must be allowed from callbacks. For this release > > lock before calling callback routine and enable them again. > Why would you like to do that? > > IMO it's not a good thing as you are essentially doing it in your tasklet... > Make sure the submit() is done by client before this and you use it to start > next transaction in you tasklet and let client know in callback txn is > finished.
No. Submission is explicitly permitted (by Dan) in slave DMA callbacks.
| |