Messages in this thread | | | Date | Tue, 26 Apr 2011 13:07:24 -0700 | From | Andrew Morton <> | Subject | Re: (resend) [PATCH] vmscan,memcg: memcg aware swap token |
| |
On Tue, 26 Apr 2011 16:59:19 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> @@ -75,3 +76,19 @@ void __put_swap_token(struct mm_struct *mm) > swap_token_mm = NULL; > spin_unlock(&swap_token_lock); > } > + > +int has_swap_token_memcg(struct mm_struct *mm, struct mem_cgroup *memcg) > +{ > + if (memcg) { > + struct mem_cgroup *swap_token_memcg; > + > + /* > + * memcgroup reclaim can disable swap token only if token task > + * is in the same cgroup. > + */ > + swap_token_memcg = try_get_mem_cgroup_from_mm(swap_token_mm); > + return ((mm == swap_token_mm) && (memcg == swap_token_memcg)); > + } else > + return (mm == swap_token_mm); > +}
Seems to be missing a css_put()?
Either I'm mistaken or that's a bug. Perhaps neither of these would have happened if we'd bothered to document try_get_mem_cgroup_from_mm().
| |