Messages in this thread | | | Subject | Re: [PATCH] linux/string.h: Introduce streq macro. | From | Steven Rostedt <> | Date | Tue, 26 Apr 2011 15:37:22 -0400 |
| |
On Tue, 2011-04-26 at 16:21 -0300, Thiago Farina wrote: > On Tue, Apr 26, 2011 at 4:20 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote: > > On Tue, Apr 26, 2011 at 03:17:48PM -0400, Steven Rostedt wrote: > >> On Tue, 2011-04-26 at 22:05 +0300, Alexey Dobriyan wrote: > >> > On Tue, Apr 26, 2011 at 03:49:49PM -0300, Thiago Farina wrote: > > > >> > > /** > >> > > + * streq - Are two strings equal? > >> > > + * @a: first string > >> > > + * @b: second string > >> > > + * > >> > > + * Example: > >> > > + * if (streq(argv[1], "--help")) > >> > > + * printf("%s\n", "This help"); > >> > >> Userspace example? > > > > The point is that function is trivial, and if someone doesn't > > understand it, he should read some Kernighan and Ritchie first. > > > > I'm fine to remove (should I Steven?). I don't care about the example. > People reading the code here knows what is this for.
Replace it with something like:
* Use this: streq(a, b) * instead of: strcmp(a, b) == 0 or !strcmp(a, b) * * This makes the code more readable and less error prone.
-- Steve
| |